EventSource as Connectable#211
Merged
BalestraPatrick merged 4 commits intospotify:masterfrom Feb 5, 2025
Merged
Conversation
dalef84
force-pushed
the
eventsource-connectable
branch
from
fc261ce to
acff1c2
Compare
dalef84
force-pushed
the
eventsource-connectable
branch
from
d27cbed to
5ed4d16
Compare
joelekstrom
approved these changes
Feb 3, 2025
joelekstrom
approved these changes
Feb 5, 2025
BalestraPatrick
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added a way to inject an eventSource of type
Connectable<Model, Event>Made it backwards compatible with existing API
Why
Allow for conditional subscriptions based on the state of the loop
Reference
Inspired by these changes